perf(records): faster autodelete candidate query#6150
Merged
TBonnin merged 1 commit intoMay 14, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35af2cc6ce
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
35af2cc to
5322447
Compare
The query to select candidates for records autodeletion is inefficient and require pg to scan the record_counts table. It is also inefficient because randomly picking a entry can potentially return entries that have already been checked recently. This commit adds a autodelete_checked_at column (with index) to the record_counts table so the query can quickly select the least recently checked entry
5322447 to
f9789cd
Compare
marcindobry
approved these changes
May 14, 2026
pfreixes
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query to select candidates for records autodeletion is inefficient and require pg to scan the record_counts table.
It is also inefficient because randomly picking a entry can potentially return entries that have already been checked recently. This commit adds a autodelete_checked_at column (with index) to the record_counts table so the query can quickly select the least recently checked entry