feat(integrations): add support for sage-200#6233
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa60b0308f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
2 issues found across 13 files
Confidence score: 2/5
- There is a concrete setup risk in
packages/server/lib/hooks/connection/providers/sage-200/post-connection.ts: defaulting toresponse.data[0]from/accounts/v1/sitescan bind integrations to the wrong company/site when multiple sites are returned, causing incorrect downstream requests. - The error path is also high impact: if
/accounts/v1/sitesfails and the hook returns silently,company_id/site_idremain unset and later Sage 200 calls can miss requiredX-Company/X-Siteheaders, leading to likely runtime failures. - Given both issues are severity 7/10 with high confidence and affect core connection initialization behavior, this carries meaningful regression risk until addressed.
- Pay close attention to
packages/server/lib/hooks/connection/providers/sage-200/post-connection.ts- site selection and failure handling must reliably set required Sage 200 context headers.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Describe the problem and your solution