Fix missing confirmation in apt-upgrade in Docker build#711
Merged
juhoinkinen merged 1 commit intoJun 7, 2023
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 95.81% 99.67% +3.85%
==========================================
Files 89 89
Lines 6380 6380
==========================================
+ Hits 6113 6359 +246
+ Misses 267 21 -246 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apt-get upgradewas added in Docker build to ensure that system packages are up-to-date in the image in PR #707, but I did not add-yoption to it, because it seemed unnecessary as the command worked while testing without it (and in this SO post the-ywas concluded to be unnecessary, but the post was aboutapt-get update!)However, it seems that when there is some packages to upgrade, then then the
-yoption is necessary. Without it the build fails: