Avoid scikit-learn UserWarning for vectorizer parameter token_pattern#729
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6397 6401 +4
=======================================
+ Hits 6376 6380 +4
Misses 21 21
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scikit-learn vectorizers used by Annif (CountVectorizer, TfidfVectorizer) trigger this warning:
This is a bit surprising, since we are not setting
token_patternourselves, but its default value is not None. This PR fixes the warning by explicitly settingtoken_pattern=Nonewhenever thetokenizerparameter is set in Annif calling code.