Skip to content

Sort language detection results by descending score#800

Merged
osma merged 1 commit into
mainfrom
issue631-language-detection-rest-sort-by-score
Sep 17, 2024
Merged

Sort language detection results by descending score#800
osma merged 1 commit into
mainfrom
issue631-language-detection-rest-sort-by-score

Conversation

@osma

@osma osma commented Sep 17, 2024

Copy link
Copy Markdown
Member

This is an improvement to the language detection REST API method (#631) which improves the implementation that was made in #659.

Results are now sorted by descending score, so the most likely language is returned first.

@osma osma added this to the 1.2 milestone Sep 17, 2024
@osma osma self-assigned this Sep 17, 2024
@sonarqubecloud

Copy link
Copy Markdown

@osma osma requested a review from juhoinkinen September 17, 2024 08:31
@codecov

codecov Bot commented Sep 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (c42a93f) to head (8564c12).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          93       93           
  Lines        6889     6889           
=======================================
  Hits         6865     6865           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juhoinkinen juhoinkinen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@osma osma merged commit c81ed1c into main Sep 17, 2024
@osma osma deleted the issue631-language-detection-rest-sort-by-score branch September 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants