Fix Docker image builds by using non-package mode for initial dependencies installation#828
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 95 95
Lines 7171 7171
=======================================
Hits 7145 7145
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poetry 2.0 was released 2 weeks ago, and Annif installation with it in Docker image builds fail, see e.g. this CICD run .
The error message is just
failed to solve: ...when installing optional dependencies, but in this comment it is stated that with Poetry 2.0 all the source code is needed to exist when runningpoetry install, not justpyproject.tomletc. files.How about just pinning Poetry to version ~=1.8 in Dockerfile for now? (Poetry has already been pinned in CICD pipeline.)Edit: There is
--no-rootoption topoetry installfor installing only dependencies frompyproject.toml, and when using it the source is not needed as with Poetry v1. So, lets us it, but also pin Poetry to ~=2.0.