Fix uploading nn-train.mdb directory to Hugging Face#933
Open
juhoinkinen wants to merge 3 commits into
Open
Conversation
Previously it was detected only in file names
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 103 103
Lines 8238 8242 +4
=======================================
+ Hits 8208 8212 +4
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request fixes the issue where the nn-train.mdb directory was being uploaded to Hugging Face when running the annif upload command. The fix modifies the filtering logic to detect training-related patterns in any part of the file path, not just the filename.
Changes:
- Renamed
_is_train_file()to_is_train_path()to better reflect its purpose - Modified the function to check all parts of a path for training patterns (e.g., "-train", "tmp-") instead of just the filename
- Updated the call site to pass the relative path instead of just the filename
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911.