-
Notifications
You must be signed in to change notification settings - Fork 322
New GCS destination plugin for uploading certificates to Google Cloud Storage #5210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
odopertchouk
wants to merge
7
commits into
Netflix:main
Choose a base branch
from
odopertchouk:odopertchouk/gcs-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+464
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uite - New GCS destination plugin for uploading certificates to Google Cloud Storage - Modular architecture with separate methods for testing and maintainability - Comprehensive error handling for GCS API exceptions - Support for certificate variable expansion (CN, OU, O, L, S, C) - Wildcard certificate handling with automatic asterisk replacement - Complete test suite with 11 tests covering all plugin functionality - Added google-cloud-storage dependency to requirements - Updated CLAUDE.md with enhanced development guidelines - All code follows PEP 8 standards and passes lint checks Features: - Configurable bucket names and object paths - Certificate and private key upload support - Robust credential validation using GOOGLE_APPLICATION_CREDENTIALS - Detailed logging for debugging and monitoring - Input validation to prevent security issues Technical Details: - Refactored upload functionality into 6 testable methods - Added type hints throughout for better code quality - Implemented proper Flask app context handling in tests - Mock-based testing for external GCS dependencies - Comprehensive docstrings with parameter and exception documentation
jmcrawford45
approved these changes
Jun 9, 2025
Contributor
jmcrawford45
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together and for adding extensive tests for it. Could you also add a changelog entry for the new feature?
The PyJWT library now enforces that the 'sub' claim must be a string, but Lemur was setting it to an integer user ID, causing token validation to fail with "Subject must be a string" errors. This fix: - Converts user IDs to strings when creating JWT tokens - Converts the subject back to int when validating tokens for user lookup - Maintains backward compatibility with existing functionality Fixes authentication issues where login succeeded but subsequent API requests returned 403 forbidden errors.
Contributor
Author
|
I have added a line to CHANGELOG.rst, is that the right format and location? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: