Correct (hopefully) master token lock cleanup in MslControl.#276
Merged
Conversation
…ter as part of its contructor, same as the Java and C++ implementations. Create JavaScript Semaphore class for synchronized access to a limited resource.
…lInternalException.
… retrieving the user ID token in buildRequest(), buildResponse(). Remove impossible call to release the master token in ReceiveService.call() when in trusted services mode. Do not release the master token (an extra time) in RequestService.execute() after the recursive call is made, but make sure to release it in all other cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly fixes #208: Do not release the master token (an extra time) in RequestService.execute() after the recursive call is made, but make sure to release it in all other cases.
Also make sure to release the master token if an exception is thrown while retrieving the user ID token in buildRequest(), buildResponse().