This repository was archived by the owner on Dec 19, 2025. It is now read-only.
Suro ping #40
Merged
Suro ping #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks a lot, Zaccus. This looks good. Somehow the cloudbee build didn't start automatically for your pull request. We'll fix the build and then merge the pull request as soon as we can. |
|
suro-pull-requests #20 SUCCESS |
g9yuayon
added a commit
that referenced
this pull request
Mar 13, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a simple ping class that periodically checks if a single suro-server is up or down.
We noticed that if there is only one suro-server and it goes down, suro-client's static load balancer marks that server as "down", and does not mark it as back "up" again if the server comes back online. This necessitates a restart of suro-client, and since we've embedded suro-client in a larger application, that is something we want to avoid.
Currently, suro-server uses a DummyPing class by default, which does nothing by design. There is ping functionality built into the load balancer already, so all this SuroPing class does is take advantage of that functionality in cases where the usual round-robining wouldn't apply.