Only warn when writing to client before LastContent when a body is expected #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalernehl
reviewed
Oct 8, 2025
| && !shouldAllowPreemptiveResponse(channel) | ||
| && zuulResponse.getInboundRequest().hasBody()) { | ||
| responseBeforeReceivedLastContentCounter.increment(); | ||
| logger.warn( |
There was a problem hiding this comment.
how is this warning useful overall?
There was a problem hiding this comment.
Can be a signal of a misbehaving client or origin; will be interesting to see how it behaves in prod given the metric should reduce/provide insight into the cases when it does legitimately happen
jguerra
approved these changes
Oct 8, 2025
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(booleans = {false, true}) |
| if (hasBodyChunk) { | ||
| request.bufferBodyContents(new io.netty.handler.codec.http.DefaultHttpContent( | ||
| Unpooled.copiedBuffer("body", java.nio.charset.StandardCharsets.UTF_8))); | ||
| } |
There was a problem hiding this comment.
I can't remember if zuul-core tests have leak detection asserts or not, but can you release this if it isn't being released somewhere else already?
There was a problem hiding this comment.
Good call - added a dispose call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client request is responded by an origin immediately whilst the client is still sending the request (i.e. the origin has enough details in the headers to respond) then warnings are logged.
This PR silences those warnings for cases when the client does not have a body but the origin still responded before the client channel
LastContentwas sent through the pipeline.Example log: