Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves cluster node removal by adding LDAP-provider cleanup steps so that providers hosted on a removed node are de-registered and remaining providers can reconfigure, reducing the risk of stale LDAP upstream entries after a node is removed.
Changes:
- Detect LDAP providers that belong to the node being removed and group remaining providers by domain.
- Notify a surviving LDAP provider (per domain) to run
leave-replicafor each removed provider’sserverid. - Publish
cluster/event/service-ldap-changedto trigger ldapproxy reconfiguration after provider removal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the handling of LDAP providers when a node is removed from the cluster. This change ensures that stale entries are purged and surviving providers are notified for reconfiguration.
NethServer/dev#7841