Skip to content

Fixed default swift version#39

Merged
gtrop1 merged 1 commit into
hotfixfrom
gt/swift-4.2-hotfix
May 2, 2019
Merged

Fixed default swift version#39
gtrop1 merged 1 commit into
hotfixfrom
gt/swift-4.2-hotfix

Conversation

@gtrop1
Copy link
Copy Markdown

@gtrop1 gtrop1 commented May 2, 2019

No description provided.

@gtrop1 gtrop1 added the swift label May 2, 2019
@gtrop1 gtrop1 added this to the 3.1.1 milestone May 2, 2019
@gtrop1 gtrop1 force-pushed the gt/swift-4.2-hotfix branch from 1f09f81 to 04658fe Compare May 2, 2019 19:53
Copy link
Copy Markdown
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments back.

Comment thread CHANGELOG.md
---

## [3.1.1](https://github.com/Nike-Inc/Elevate/releases/tag/3.1.1)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the release section here linking the milestone.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing the release at the top.

Addressed issue where Swift version was incorrectly set to 5.0 when it should have been 4.2.
@gtrop1 gtrop1 force-pushed the gt/swift-4.2-hotfix branch from 04658fe to b570106 Compare May 2, 2019 20:20
Copy link
Copy Markdown
Member

@cnoon cnoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gtrop1 gtrop1 merged commit 13d37c4 into hotfix May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants