fix(readme): changed editor install instructions for nvim 0.11#414
Conversation
… changes in nvim 0.11
neovim 0.11 changed the way of configuring lsp's to now use
vim.lsp.config(), with this require("lspconfig") is now deprecated. (I
do not know if the changes affect non-ls).
jfly
left a comment
There was a problem hiding this comment.
Untested, but seems fine to me.
|
Thanks, @indexhd! |
|
first ever pull request, happy to contribute to open source, even if its not code 😃 |
MattSturgeon
left a comment
There was a problem hiding this comment.
Sorry, I started this review earlier but wasn't able to finish it until now.
Happy to open a follow up PR, but let's discuss here first.
(Thanks for updating our docs!)
| settings = { | ||
| ['nil'] = { | ||
| formatting = { | ||
| vim.lsp.config['nil'] = { |
There was a problem hiding this comment.
I believe the intended API is to call config as a function, not assign to its table properties directly.
| vim.lsp.config['nil'] = { | |
| vim.lsp.config('nil', { |
This allows defining the config for the same LSP multiple times; if you assign to the table property, you overwrite previous config.
We also want vim.lsp.enable('nil') as well.
(same for nixd, ofcourse)
There was a problem hiding this comment.
There was a problem hiding this comment.
oh yes, that seems smarter than what i did, i'l have to change that in my config 🙃
|
Thanks @MattSturgeon! Should have waiting for our resident neovim expert before merging. If this isn't fixed in a week, I'll do it. |
neovim 0.11 changed the way of configuring lsp's to now use vim.lsp.config(), with this require("lspconfig") is now deprecated. (I do not know if the changes affects non-ls).