fix: custom favicon #11970
Open
fix: custom favicon #11970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if favicon was uploaded and not stored in static upload folder, this logic is wrong, it should be used from Meta.config instead.
Member
|
@noscripter what was the value stored in The code seems to always save the file at |
Contributor
Author
|
@barisusakli that's not the case when you use some plugins to override the uploadFavicon function found in ACP. Oh, I see, I've customized this function to response to the hook filter:uploadImage. Maybe this could be proposed to change too, I'll come up with these changes later for you to check out.🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if favicon was uploaded and not stored in static upload folder, this logic is wrong, it should be used from Meta.config instead.