Fixes #27891: IncludeSystem in import library is always false and can't be true #6722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
PR updated with a new commit |
Contributor
|
This PR is not mergeable to upper versions. |
Member
Author
|
OK, squash merging this PR |
a6bd4cb to
6904c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/27891
This PR "just" remove all
includeSystemfrom theswapGroupLibraryandswapActiveTechniqueLibrarymethods, and all the calling parameter depending on it.All
ifwhere looking like&& includeSystem == false, so sinceincludeSystemis always false, code logic change were just removing that part.It also correct typos, change interpolation to the "modern" (humpf humpf) way of doing string interpolation in scala, and add some precision in some logs.