Skip to content

Fixes #27909: Use pre+mono font for reports #6735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Normation-Quality-Assistant merged 1 commit into from
Nov 27, 2025
Merged

Fixes #27909: Use pre+mono font for reports #6735

Normation-Quality-Assistant merged 1 commit into from
Nov 27, 2025

Conversation

@RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented Nov 20, 2025

clarktsiory
clarktsiory approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it will likely conflict with #6737 which hash been merged, so I suggest a rebase

@Normation-Quality-Assistant
Copy link
Contributor

Normation-Quality-Assistant commented Nov 27, 2025

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/6735
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/110409/console)

@Normation-Quality-Assistant
Copy link
Contributor

Normation-Quality-Assistant commented Nov 27, 2025

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/6735
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/110411/console)

@RaphaelGauthier
Copy link
Member Author

RaphaelGauthier commented Nov 27, 2025

PR rebased

@RaphaelGauthier RaphaelGauthier force-pushed the enh_27909/use_pre_mono_font_for_reports branch from 057dfff to bcc4107 Compare November 27, 2025 09:55
@Normation-Quality-Assistant
Copy link
Contributor

Normation-Quality-Assistant commented Nov 27, 2025

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit bcc4107 into Normation:branches/rudder/8.3 Nov 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarktsiory clarktsiory clarktsiory approved these changes

Assignees

No one assigned

Labels

Ready for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RaphaelGauthier @Normation-Quality-Assistant @clarktsiory