Skip to content

Fixes #27959: Upmerge of 25061 fails test compilation due to scala 3 macros #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanf merged 1 commit into from
Dec 1, 2025
Merged

Fixes #27959: Upmerge of 25061 fails test compilation due to scala 3 macros #6755

fanf merged 1 commit into from
Dec 1, 2025

Conversation

@clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Dec 1, 2025 •
edited
Loading

https://issues.rudder.io/issues/27959

assertTrue in zio-test is macro-based, and it breaks our test abstraction (here : a loan pattern).
Test abstractions need to make use of the classic Assertion API instead

@clarktsiory clarktsiory requested a review from fanf December 1, 2025 12:19
@clarktsiory clarktsiory changed the base branch from branches/rudder/9.1 to branches/rudder/8.3 December 1, 2025 12:23
fanf
fanf approved these changes Dec 1, 2025
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarktsiory
Copy link
Contributor Author

clarktsiory commented Dec 1, 2025

PR rebased

@clarktsiory clarktsiory force-pushed the bug_27959/upmerge_of_25061_fails_test_compilation_due_to_scala_3_macros branch from 405f4cb to 4bb890f Compare December 1, 2025 15:13
@Normation-Quality-Assistant
Copy link
Contributor

Normation-Quality-Assistant commented Dec 1, 2025

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/6755
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/110609/console)

@fanf
Copy link
Member

fanf commented Dec 1, 2025

OK, merging this PR

@fanf fanf merged commit 4bb890f into Normation:branches/rudder/8.3 Dec 1, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanf fanf fanf approved these changes

Assignees

No one assigned

Labels

qa: Can't merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clarktsiory @Normation-Quality-Assistant @fanf