[14.0][IMP] web_company_color: Forward port #1903 from 12.0#2209
Conversation
| "color_link_text", | ||
| "color_link_text_hover", | ||
| ) | ||
| if "logo" in values: |
There was a problem hiding this comment.
You seem to be undoing https://github.com/OCA/web/pull/2158/files. Is that on purpose?
There was a problem hiding this comment.
Ah, good catch. I didn't really follow this module's history and just ported the commit trying to preserve as much of it as possible.
Thank you 🙏
Fixing it now.
See upstream commit: odoo/odoo@0bc24a7
|
Added a commit to fix #2248 |
|
@hbrunn your improvement is being forward ported! Care to review? |
|
This PR has the |
1 similar comment
|
This PR has the |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 1374fbd. Thanks a lot for contributing to OCA. ❤️ |
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
I'm late to this, but I just hit into this change. I see 2 problems:
- Starting with the field in blank you need to set all fields in order for it to have an effect. (you cannot just set the navbar colors for instance).
- When computing colors from logo, only the nabvar ones are filled.
Forward port of #1903
commit e18209c