Skip to content

[14.0][FIX] web_drop_target: check controller is not null#2299

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
ecosoft-odoo:14.0-fix-web_drop_target_jsID
Sep 30, 2022
Merged

[14.0][FIX] web_drop_target: check controller is not null#2299
OCA-git-bot merged 1 commit into
OCA:14.0from
ecosoft-odoo:14.0-fix-web_drop_target_jsID

Conversation

@Saran440

@Saran440 Saran440 commented Sep 23, 2022

Copy link
Copy Markdown
Member

fix it from issue #2298

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 23, 2022
@pedrobaeza

pedrobaeza commented Sep 24, 2022

Copy link
Copy Markdown
Member

Please fix pre commit

@Saran440 Saran440 force-pushed the 14.0-fix-web_drop_target_jsID branch from c280700 to 1d0498f Compare September 29, 2022 11:07
pedrobaeza
pedrobaeza approved these changes Sep 30, 2022
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works itself. Let's see how it works with DMS.

@pedrobaeza

pedrobaeza commented Sep 30, 2022

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2299-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 87e3767 into OCA:14.0 Sep 30, 2022
@OCA-git-bot

OCA-git-bot commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f6cc64b. Thanks a lot for contributing to OCA. ❤️

@KKamaa

KKamaa commented Dec 19, 2022

Copy link
Copy Markdown

Hey guys this fix messed up the module could you please retest. I'm going through it too cause once it was added we can't be able to drag and drop files.

@Saran440

Saran440 commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

@KKamaa Sorry, I'm not expert JS. Can you help fix it, please?

@KKamaa KKamaa mentioned this pull request Dec 27, 2022
Merged
@KKamaa

KKamaa commented Dec 27, 2022 •
edited
Loading

Copy link
Copy Markdown

@KKamaa Sorry, I'm not expert JS. Can you help fix it, please?

did the fix here ->PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+1 more reviewer

@ps-tubtim ps-tubtim ps-tubtim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Saran440 @pedrobaeza @OCA-git-bot @KKamaa @ps-tubtim