[16.0][MIG] shopfloor_gs1#966
Conversation
39e5ade to
a612edd
Compare
simahawk
left a comment
There was a problem hiding this comment.
LGTM
@rousseldenis can you rebase and cleanup? 🙏
| """ | ||
| We must return the date value if set | ||
| We must return the formatted GTIN if set | ||
| as the library will transform the GTIN 14 into | ||
| a GTIN 13 one. That one is the barcode | ||
| set in Odoo. |
There was a problem hiding this comment.
| """ | |
| We must return the date value if set | |
| We must return the formatted GTIN if set | |
| as the library will transform the GTIN 14 into | |
| a GTIN 13 one. That one is the barcode | |
| set in Odoo. | |
| """ | |
| Determine the final value for the given parsed element. | |
| Returns | |
| * date value if set | |
| * formatted GTIN if set | |
| The library will transform the GTIN 14 into | |
| a GTIN 13, which is the one used by Odoo. |
|
One more thing: as the v14 PR was never merged, IMO we can squash the fixup commit ;) |
| # >= 2.3.0 required to use 'GS1Message.parse_hri' method | ||
| # and next version 3.0.0 has been refactored bringing | ||
| # incompatibility issues (to check later). | ||
| "biip" |
There was a problem hiding this comment.
the pin of the lib is lost here. It's mandatory as there's no other 2.x version that is suitable
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
If you are specifically searching for a type and this type is not supported by our AI mapping, just don't search for it. This is kind of mandatory because otherwise the GS1 parsing will default to all available AIs and can give back unexpected results (eg: search for 'package' and get an empty 'product' back)
As products barcode in Odoo are stored in GTIN-13 (EAN-13), and as GS1 contains the GTIN-14 representation, don't mix them in tests
6da2cd6 to
c096146
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at e11279d. Thanks a lot for contributing to OCA. ❤️ |
From:
Depends on: