[18.0][ADD] sale_product_identification_pos #1433
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9153d6 to
275f86b
Compare
275f86b to
e2afedf
Compare
Author
|
Hi @rrebollo @arielbarreiros96 @Christian-RB @rousseldenis @epieters, if you could review this PR, thank you. |
rrebollo
suggested changes
Sep 30, 2025
rrebollo
left a comment
There was a problem hiding this comment.
📝 Code Review: Great work! 🎉 The code looks good to me (LGTM) ✅
Thank you for your contribution! 🙌
I've added a few suggestions: some are timely to address now, while others you may consider later (or not). 😉
sale_product_identification_pos/models/res_partner_id_number.py
Outdated
Show resolved
Hide resolved
sale_product_identification_pos/models/res_partner_id_number.py
Outdated
Show resolved
Hide resolved
sale_product_identification_pos/models/res_partner_id_number.py
Outdated
Show resolved
Hide resolved
sale_product_identification_pos/models/res_partner_id_number.py
Outdated
Show resolved
Hide resolved
e2afedf to
51f50b4
Compare
51f50b4 to
81376c8
Compare
|
@edescalona You requested my review but several test are currently failing. Please tag me when they are green. |
eef87a3 to
71ff962
Compare
Verify the product ID when confirming an order at the point of sale
71ff962 to
1e171c1
Compare
1e171c1 to
1b6e2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
This module allows, when confirming an order at the point of sale, the identifications required by the product(s) added to the lines are validated, thus facilitating the sale to an authorized customer.