Repository navigation
Fix Decimal128 conversion #34
Description
Currently, when we convert wirebson.Decimal128 value to the JavaScript representation, we do:
https://github.com/OpenDocDB/cts/blob/main/opendocdb-cts/internal/mongosh/mongosh.go#L121-L122
This is incorrect, and results in different value than expected. The H, and L represent the most significant and least significant bits of 128-bit IEEE 754-2008 decimal floating value.
The fix could be done on cts layer, but we could also consider extending wire/wirebson package with a new function.
Where
- TODO comments referencing this issue,
- integration tests skipped with reference.
Activity
AlekSi commentedon Apr 16, 2025
Isn't it the same as #22?
noisersup commentedon Apr 16, 2025
@AlekSi I don't think so. The problem that exists here is related to our way of converting
wirebsonDecimal128 into mongosh JS. The #22 doesn't involve any wirebson->mongosh conversion.AlekSi commentedon Apr 16, 2025
I don't follow. The title of #22 literally starts with "Fixture conversion to mongosh".
noisersup commentedon Apr 16, 2025
I see, then yeah, I think those might be related.