Skip to content

Change ECM and Hacker Tanks#1084

Merged
Mailaender merged 4 commits into
OpenHV:mainfrom
WilliamWeberBerrutti:ChangeECMAndHackerTanks
Sep 6, 2024
Merged

Change ECM and Hacker Tanks#1084
Mailaender merged 4 commits into
OpenHV:mainfrom
WilliamWeberBerrutti:ChangeECMAndHackerTanks

Conversation

@WilliamWeberBerrutti
Copy link
Copy Markdown
Contributor

@WilliamWeberBerrutti WilliamWeberBerrutti commented Jul 29, 2024 •
edited
Loading

This PR changes the following:

  • changes prerequisite for both tanks to be Factory, Radar and Trader
  • balances ECM Tank by increasing disabling duration, having seeker projectile, allowing disabling only for enemy units, increasing HP, increasing speed and turnspeed and changing armor type
  • balances Hacker Tank by removing damage from its projectile, changing armor type, increasing HP and cost and reducing speed
  • increases LOS of Radar Tank and Saucer
  • prevents empty resource tankers from being hacked and disabled
  • makes Radar Tank selectable with military units

Mailaender
Mailaender reviewed Jul 29, 2024
View reviewed changes
Comment thread mods/hv/rules/vehicles.yaml
GraionDilach
GraionDilach reviewed Jul 30, 2024
View reviewed changes
Comment thread mods/hv/weapons/energetic.yaml
OcelotWalrus
OcelotWalrus suggested changes Jul 30, 2024
View reviewed changes
Comment thread mods/hv/languages/rules/en.ftl Outdated
Comment thread mods/hv/languages/rules/en.ftl Outdated
OcelotWalrus
OcelotWalrus reviewed Jul 31, 2024
View reviewed changes
Comment thread mods/hv/languages/rules/en.ftl Outdated
@WilliamWeberBerrutti WilliamWeberBerrutti force-pushed the ChangeECMAndHackerTanks branch 3 times, most recently from a60e621 to fdfbbf2 Compare August 6, 2024 18:43
@WilliamWeberBerrutti WilliamWeberBerrutti force-pushed the ChangeECMAndHackerTanks branch 2 times, most recently from 6e3fc7a to 33e7a2d Compare August 7, 2024 23:07
@WilliamWeberBerrutti WilliamWeberBerrutti force-pushed the ChangeECMAndHackerTanks branch 8 times, most recently from 11c82ac to e606c39 Compare September 2, 2024 22:43
@WilliamWeberBerrutti WilliamWeberBerrutti marked this pull request as ready for review September 3, 2024 11:06
Mailaender
Mailaender reviewed Sep 3, 2024
View reviewed changes
Comment thread mods/hv/languages/rules/en.ftl Outdated
@WilliamWeberBerrutti WilliamWeberBerrutti force-pushed the ChangeECMAndHackerTanks branch 4 times, most recently from 6f69f8d to e8d0dc3 Compare September 4, 2024 20:44
@WilliamWeberBerrutti
Copy link
Copy Markdown
Contributor Author

WilliamWeberBerrutti commented Sep 4, 2024

I had to do more changes. I think I didn't forget anything.

@Rampoina
Copy link
Copy Markdown
Contributor

Rampoina commented Sep 5, 2024

@WilliamWeberBerrutti says it shouldn't be merged yet, he wants to do more tests and some changes.

@Mailaender Mailaender marked this pull request as draft September 5, 2024 17:09
@WilliamWeberBerrutti
Copy link
Copy Markdown
Contributor Author

WilliamWeberBerrutti commented Sep 5, 2024

@WilliamWeberBerrutti says it shouldn't be merged yet, he wants to do more tests and some changes.

I think it's good now!

@WilliamWeberBerrutti WilliamWeberBerrutti marked this pull request as ready for review September 5, 2024 18:05
@Mailaender Mailaender merged commit 3dabcb6 into OpenHV:main Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mailaender Mailaender Mailaender left review comments

+2 more reviewers

@GraionDilach GraionDilach GraionDilach left review comments

@OcelotWalrus OcelotWalrus OcelotWalrus requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@WilliamWeberBerrutti @Rampoina @Mailaender @GraionDilach @OcelotWalrus