Skip to content

Remove metadata from TrajectoryGroup, keep only on Trajectory#208

Merged
corbt merged 1 commit into
mainfrom
remove-trajectory-metadata
Jul 8, 2025
Merged

Remove metadata from TrajectoryGroup, keep only on Trajectory#208
corbt merged 1 commit into
mainfrom
remove-trajectory-metadata

Conversation

@corbt

@corbt corbt commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Summary

  • Removed metadata field from TrajectoryGroup class
  • Updated all constructors and methods to remove metadata parameter
  • Updated serialization/deserialization in trajectory_logging.py

Rationale

We're not aware of anyone using group-level metadata, and this change provides several benefits:

  • Simpler schema for ingesting into experiment tracking tools
  • Clearer mental model of where to store metadata (only on individual trajectories)
  • Reduced complexity in the data model

Users who need group-level metadata can still achieve this by setting the same metadata on each trajectory in the group.

Changes

  • Removed metadata: dict[str, MetadataValue] = {} field from TrajectoryGroup
  • Removed metadata parameter from all TrajectoryGroup constructors and overloads
  • Updated trajectory_logging.py to no longer serialize/deserialize group metadata
  • No existing tests needed updating (no tests existed for this functionality)

We can add this functionality back later if it proves necessary.

🤖 Generated with Claude Code

This simplifies the data model by only allowing metadata on individual
trajectories rather than on trajectory groups. Users who need group-level
metadata can set the same metadata on each trajectory in the group.

Benefits:
- Simpler schema for ingesting into experiment tracking tools
- Clearer mental model of where to store metadata
- No known users of group-level metadata functionality

We can add this back later if it proves necessary.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@corbt corbt requested a review from bradhilton July 8, 2025 01:20
@corbt corbt merged commit 4b9c9c8 into main Jul 8, 2025
2 checks passed
surajpatildev pushed a commit to meetkiara/ART that referenced this pull request May 20, 2026
Remove metadata from TrajectoryGroup, keep only on Trajectory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants