Skip to content

Fix bogus RA tab artwork #5926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mailaender merged 5 commits into from
Jul 11, 2014
Merged

Fix bogus RA tab artwork #5926

Mailaender merged 5 commits into from
Jul 11, 2014

Conversation

@pchote
Copy link
Member

@pchote pchote commented Jul 11, 2014

I was really disappointed to see just how broken these were:

  • Soviet tab coordinates were off by 1px in the texture atlas.
  • Soviet-normal tab glyphs were off by 1px.
  • Allied-selected tabs had random semi-transparent pixels.
  • Most tabs had a discoloured pixel near the left edge.
  • Added captured-tech tab versions for aircraft (wired up) and ships (not wired up).
  • Removed multiple bitrotted source art versions (none of which had correct layers).

Fixes #5915.

@pchote pchote added this to the July 2014 Release milestone Jul 11, 2014
@Mailaender
Copy link
Member

Mailaender commented Jul 11, 2014

This introduces some visual glitches on the top. This is best viewed on a snow map when switching tabs:

image

image

@pchote
Fix bogus inconsistencies in the ra tab images:
393702f 
- Soviet-normal tab glyphs were off by 1px.
- Allied-selected tabs had random semi-transparent pixels.
- Most tabs had a discoloured pixel near the left edge.
@pchote
Copy link
Member Author

pchote commented Jul 11, 2014

Updated.

Mailaender added a commit that referenced this pull request Jul 11, 2014
@Mailaender
Merge pull request #5926 from pchote/ra-tabs
a357bce 
Fixes #5915
@Mailaender Mailaender merged commit a357bce into OpenRA:bleed Jul 11, 2014
@Mailaender
Copy link
Member

Mailaender commented Jul 11, 2014

Thanks for the cleanup in artsrc.

@Mailaender
Copy link
Member

Mailaender commented Jul 11, 2014

https://github.com/OpenRA/OpenRA/wiki/Changelog/_compare/491601ebc807923b1d7e4e598d0a59a07a646ee6...127040f245ab15e83d64a7bbb411842e17009f06

@pchote pchote deleted the ra-tabs branch July 19, 2014 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

release-20140722

Development

Successfully merging this pull request may close these issues.

Helicopter and Plane buttons at RA

3 participants

@pchote @Mailaender @DanielHernandez