OTP compatibility and dialyzer issues #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks behaviour (e.g. float conversion) for earlier OTP versions, but will still compile/run. In Riak use case, no issues with float conversion or non-utf8 atom conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two OTP compatibility issues:
[short]option on float_to_binary, is not available until OTP 25. Without converting floats to-and-from may not return the same results. As we don't include floats in JSON in Riak, we wrok around this for earlier versions, and disable the relevant tests.binary_to_atom/1andbinary_to_existing_atom/1are not available in OTP 22 - so the equivalent 2-arity function is used. Again there is no conversion of atoms in Riak's use - and so this is not relevant.The remaining issue is a large number of dialyzer warnings about improper lists. See OTP discussion on this warning - erlang/otp#5937. I'm not sure of the relevance, so rather than attempt to "fix" the code, the decision here is to trust the code and disable the warning.