-
Notifications
You must be signed in to change notification settings - Fork 802
Adding support for DNIe. #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
@JenkinsForOpenSC ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change duplicates the line for sc_hsm_tool. It is a result of the squashing of the commits history, and it should be removed.
|
Is there any action required from my part in order to fix these two errors or will they be solved in the merge? |
|
It is strange these two patches have not be removed after the rebase. |
|
Sorry about that, I must have made a mistake with the rebase. The initial for of the repository was from somewhere in April, but it also had several merges trying to keep up-to-date with the changes in OpenSC/master. When doing the rebase with upstream it went back to the April commit of OpenSC, so I selected manually only the commits that were related with DNIe on top of that. The additional change in configure.ac must have been included by my error when doing this. |
|
Are there any actions required on my part to continue with this? |
Adding support for DNIe.
|
Please update the wiki pages. |
|
Update the wiki pages at github.com only. |
|
Thanks a lot! |
|
timofonic, you should use the OpenSC opensc-devel mailing list at https://lists.sourceforge.net/lists/listinfo/opensc-devel |
This is a Pull request with the same goal as #167.
This one has a clean history with just one commit and strictly the changes required for DNIe support.