Implement storage of Elliptic Curve keys (EVP_PKEY_EC) in pkcs11_store_key() #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_key(). This implementation is based on OpenSC's parse_ec_pkey() in src/tools/pkcs11-tool.c. Signed-off-by: Nicolas Savatier <nicolas.savatier@viveris.fr>
|
@NSavatier Are you working on fixing the failed tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, storage of EC keys (EVP_PKEY_EC) is not supported in pkcs11_store_key().
This prevents from using PKCS11_store_private_key() (defined in libp11.h) to store this type of keys.
This proposition of implementation reuses the parse_ec_pkey() function from OpenSC's pkcs11-tool (see : https://github.com/OpenSC/OpenSC/blob/master/src/tools/pkcs11-tool.c#L4103 ) to add support for storage of EC keys.
For information, we've tested this implementation manually with openssl 3.0.13 on an NXP S32G-VNP-RDB2 card.