Skip to content

Conversation

@Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Jun 20, 2025

This makes the tag movement consistent to how it behave with cloning/adding frames.
in short tag behavior when moving frames from [A, B, C, ...] to [G, H, I, ...] will be the same as if: frames at indices [A, B, C, ...] is removed and new frames at [G, H, I, ...] is created
Note that the behavior at tag edges is a little different for the sake of making it more intuitive

It works like follows:

  • If the entire tag is selected, then the tag moves as a whole (WITH the frames), if not then the frames are taken away from the tag and it's size decreases.
  • The if frames are moved from point A to point B, the tags between these points move to the right
  • The frames dropped inside the tag increases the size of the tag. (the boundary of the tag is not part of the tag)

I don't think anything got broken but testing is appreciated nonetheless

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@OverloadedOrama OverloadedOrama merged commit d4f0edc into Orama-Interactive:master Jul 4, 2025
4 checks passed
@Variable-ind Variable-ind deleted the improve-tags-motion branch July 4, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants