Send 0.01 amount to TaxJar when sum of unit_price of line_items is 0 #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning default empty $taxes array we return false so the tax calculation is stopped when we have no response.
dustinparker
approved these changes
Sep 22, 2025
Collaborator
dustinparker
left a comment
There was a problem hiding this comment.
This fixes the case where the incorrect tax rate is saved when the line items' total amount is zero. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send 0.01 amount to TaxJar when sum of unit_price of line_items is 0.
TaxJar when all line items price is 0, TaxJar
rateresponse prop is also 0 instead or default rate for given address.Only affects "As a single total" setting, as "Itemized" use traversing through response line items tax rates where rate is not 0 even for 0 unit_price item.
Related issue(s)
fixes https://linear.app/a8c/issue/WOOSHIP-1453/automatic-taxes-not-calculated-for-subscription-renewals-when-theres-a
fixes https://linear.app/a8c/issue/WOOSHIP-1482/ensure-compatibility-with-woocommerce-subscriptions
Steps to reproduce & screenshots/GIFs
Create Simple Product with price $0.00
Set tax display in Woo-> Settings -> Tax to "As a single total"
Add product to cart and go to checkout
Add shipping address that should have taxes calculated
On
trunksee the saved tax Rate for given address is 0On this branch see correct rate is saved
Checklist
changelog.txtentry addedreadme.txtentry added