Fix: health reset on join#534
Open
DeathGOD7 wants to merge 5 commits into
Open
Conversation
also changed to monitor priority so it can decide at end or so (even if delayed task will run kind of similar)
…nto fix/health-reset
Contributor
Author
|
Also, this was the exception it printed on console (eco 7.6.2): |
CallumJohnson
requested changes
Jun 10, 2026
CallumJohnson
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple changes to address, nice work !!
Contributor
Author
|
Doing build check before publishing changes to branch. |
add: new config key "health-fix-duration" add: new helper function named "getNewHealth" remove: duplicate or unnecessary variables with same value chore: made code more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before it would just check after 5 tick for health update, and it will permanently update the health regardless of old saved health.
Since some plugin might load after eco, there can be issue of health reset bug. (as stated in discord)
I have implemented task to run on interval each tick for 100 tick for health change.