-
-
Notifications
You must be signed in to change notification settings - Fork 40
Sveltekit migration #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sveltekit migration #188
Conversation
- Improve charge coloring (although two charges of the same type will still share the same secondary/tertiary tinctures) - Support zoom level option - Support outside charges - Support inscriptions and font loading
|
@Azgaar Provided it runs well on your end, I think the work here is mostly done. As for the changes in FMG, what would you suggest? |
|
Please check the build issue: FMG changes are pretty simple - change link on FMG site, and potentially more all the emblems logic from FMG to Armoria using the API. |
|
Latest version of convert-svg requires Node.js 22. This is configurable in Vercel settings, Build and Deployment tab (or we can revert b70638b). Regarding FMG, I wonder if calling the API will lead to too many requests or not, and how we can handle offline use. |
Done.
It may be too many requests, but we don't show Emblems by default so I'm not sure how stressful for the server it can actually be. For the offline use, I'm not sure we need it. Offline usage is already limited as we use some services. It's not good to remove any existing functionality, but it will make things easier, than we can do it. |
|
Getting errors on API, see below. Maybe you want to join the team on Vercel to be able to debug it? I'm 95% sure I won't be able to put any significant effort to this project in the nearest future. 2025-07-15T18:05:23.791Z [info] --------------- |
|
Yes I'll ask for access. |
|
@Blipz, just checked, members are only available on pro plan that it pretty expensive. I believe you can deploy it under your own account for now. Updated: actually it allows one |
|
Apparently, access granting didn't work. Anyway, shouldn't the https://armoria.vercel.app URL be publicly accessible? |
|
It's available, but it reflects the main branch, not the branch we want. |
|
I don't think that's the case, I get redirected to a login page when i try to access it. |
No description provided.