Skip to content

Conversation

@Azgaar
Copy link
Owner

@Azgaar Azgaar commented Jul 9, 2025

No description provided.

Blipz and others added 30 commits July 25, 2024 01:58
- Improve charge coloring (although two charges of the same type
  will still share the same secondary/tertiary tinctures)
- Support zoom level option
- Support outside charges
- Support inscriptions and font loading
@Blipz
Copy link
Collaborator

Blipz commented Jul 15, 2025

@Azgaar Provided it runs well on your end, I think the work here is mostly done.

As for the changes in FMG, what would you suggest?

@Azgaar
Copy link
Owner Author

Azgaar commented Jul 15, 2025

Please check the build issue:

[16:40:50.671] Running build in Washington, D.C., USA (East) – iad1
[16:40:50.678] Build machine configuration: 2 cores, 8 GB
[16:40:50.749] Cloning github.com/Azgaar/Armoria (Branch: sveltekit, Commit: b975441)
[16:40:53.103] Cloning completed: 2.353s
[16:40:54.541] Restored build cache from previous deployment (FDgomA8VeP22Dmhs8nZqnKFzNEz4)
[16:40:55.094] Running "vercel build"
[16:40:56.408] Vercel CLI 44.3.0
[16:40:57.517] Installing dependencies...
[16:40:58.354] npm error code EBADENGINE
[16:40:58.354] npm error engine Unsupported engine
[16:40:58.355] npm error engine Not compatible with your version of node/npm: convert-svg-core@0.7.1
[16:40:58.355] npm error notsup Not compatible with your version of node/npm: convert-svg-core@0.7.1
[16:40:58.355] npm error notsup Required: {"node":">=22"}
[16:40:58.355] npm error notsup Actual:   {"npm":"10.8.2","node":"v20.19.3"}
[16:40:58.356] npm error A complete log of this run can be found in: /vercel/.npm/_logs/2025-07-15T14_40_57_626Z-debug-0.log
[16:40:58.369] Error: Command "npm install" exited with 1
[16:40:58.569] 
[16:41:01.433] Exiting build container

FMG changes are pretty simple - change link on FMG site, and potentially more all the emblems logic from FMG to Armoria using the API.

@Blipz
Copy link
Collaborator

Blipz commented Jul 15, 2025

Latest version of convert-svg requires Node.js 22. This is configurable in Vercel settings, Build and Deployment tab (or we can revert b70638b).

Regarding FMG, I wonder if calling the API will lead to too many requests or not, and how we can handle offline use.

@Azgaar
Copy link
Owner Author

Azgaar commented Jul 15, 2025

Latest version of convert-svg requires Node.js 22. This is configurable in Vercel settings, Build and Deployment tab (or we can revert b70638b).

Done.

Regarding FMG, I wonder if calling the API will lead to too many requests or not, and how we can handle offline use.

It may be too many requests, but we don't show Emblems by default so I'm not sure how stressful for the server it can actually be. For the offline use, I'm not sure we need it. Offline usage is already limited as we use some services. It's not good to remove any existing functionality, but it will make things easier, than we can do it.

@Azgaar
Copy link
Owner Author

Azgaar commented Jul 15, 2025

Getting errors on API, see below. Maybe you want to join the team on Vercel to be able to debug it? I'm 95% sure I won't be able to put any significant effort to this project in the nearest future.

2025-07-15T18:05:23.791Z [info] ---------------
2025-07-15T18:05:23.791Z [info] Field: { t1: 'fretty-argent-gules-smaller', shield: 'heater' }
2025-07-15T18:05:23.791Z [info] Division: { division: 'perFess', line: 'straight', t: 'masoned-vert-or' }
2025-07-15T18:05:23.791Z [info] Ordinary: { ordinary: 'pall', t: 'azure' }
2025-07-15T18:05:23.808Z [error] TypeError: COA.render is not a function
at render (file:///var/task/vercel/path0/.svelte-kit/output/server/chunks/renderer.js:763:19)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async GET (file:///var/task/vercel/path0/.svelte-kit/output/server/entries/endpoints/api/_server.ts.js:23:15)
at async render_endpoint (file:///var/task/vercel/path0/.svelte-kit/output/server/index.js:222:22)
at async resolve2 (file:///var/task/vercel/path0/.svelte-kit/output/server/index.js:3056:22)
at async Object.handle (file:///var/task/vercel/path0/.svelte-kit/output/server/chunks/hooks.server.js:2:20)
at async respond (file:///var/task/vercel/path0/.svelte-kit/output/server/index.js:2941:22)
at async Object.default [as handler] (file:///var/task/vercel/path0/.svelte-kit/vercel-tmp/index.js:41:3)
at async Server.r (/opt/rust/nodejs.js:2:14648)
at async Server. (/opt/rust/nodejs.js:16:7420)

@Blipz
Copy link
Collaborator

Blipz commented Jul 15, 2025

Yes I'll ask for access.

@Azgaar
Copy link
Owner Author

Azgaar commented Jul 15, 2025

@Blipz, just checked, members are only available on pro plan that it pretty expensive. I believe you can deploy it under your own account for now.

Updated: actually it allows one access-user on a free plan.

@Blipz
Copy link
Collaborator

Blipz commented Aug 2, 2025

Apparently, access granting didn't work. Anyway, shouldn't the https://armoria.vercel.app URL be publicly accessible?

@Azgaar
Copy link
Owner Author

Azgaar commented Aug 3, 2025

It's available, but it reflects the main branch, not the branch we want.

@Blipz
Copy link
Collaborator

Blipz commented Aug 3, 2025

I don't think that's the case, I get redirected to a login page when i try to access it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants