Description

This pull request refactors how subscription data is passed to Resource Graph queries across the codebase, improving type safety and simplifying the API. It introduces a new QueryOptions struct for optional query features, updates all scanner modules to use a map[string]string for subscriptions instead of slices of pointers, and removes redundant code for preparing subscription lists. Additionally, it enables management group scope for policy queries via the new options struct.

API and Query Handling Improvements:

• Updated GraphQueryClient.Query to accept subscriptions as a map[string]string (from []*string), improving clarity and type safety. All call sites in scanner modules are updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
• Introduced QueryOptions struct to control optional query features (e.g., ManagementGroupScope), and refactored query batching and pagination logic for clarity and maintainability. [1] [2]
• Enabled management group scope for Azure Policy queries by passing QueryOptions{ManagementGroupScope: true} where needed.

Code Simplification and Cleanup:

• Removed repetitive code that converted subscription maps to pointer slices throughout scanner modules, reducing boilerplate and potential for errors. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
• Removed unnecessary deduplication logic in the Advisor scanner, relying on the query itself for uniqueness. [1] [2]

Scanner Module Adjustments:

• Updated all scanners (Advisor, ArcSQL, Azure Policy, Defender, OpenAI Throttling, and ResourceDiscovery) to use the new query API and pass subscription maps, and to utilize the subscription name mapping directly for result enrichment. [1] [2]

These changes collectively streamline Resource Graph querying, reduce duplicated code, and provide a more flexible and robust interface for future enhancements.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #882

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Unit tests passing