Skip to content

Conversation

@trevorknight
Copy link
Contributor

error: implicit conversion of NULL constant to 'char' [-Werror,-Wnull-conversion]

We can avoid this warning by just explicitly setting the null char.

@hkchung72
Copy link
Contributor

yes, it makes sense.

@jwcullen jwcullen self-requested a review April 24, 2024 13:56
Copy link
Collaborator

@jwcullen jwcullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sunghee-hwang
Copy link
Collaborator

Please hold merging this until releasing the v1.0.0-errata

@jwcullen
Copy link
Collaborator

jwcullen commented May 9, 2024

@sunghee-hwang Looks like the repo released v1.0.0-errata. Can this and other outstanding PRs be merged in?

@sunghee-hwang
Copy link
Collaborator

@sunghee-hwang Looks like the repo released v1.0.0-errata. Can this and other outstanding PRs be merged in?

I think so.

@jwcullen jwcullen merged commit f936556 into AOMediaCodec:main May 16, 2024
Luiz-Monad pushed a commit to Luiz-Monad/libiamf that referenced this pull request Sep 15, 2025
Change implicit NULL char conversion to explicit \0 char
Luiz-Monad pushed a commit to Luiz-Monad/libiamf that referenced this pull request Sep 15, 2025
Change implicit NULL char conversion to explicit \0 char
Luiz-Monad pushed a commit to Luiz-Monad/libiamf that referenced this pull request Sep 28, 2025
Change implicit NULL char conversion to explicit \0 char
Luiz-Monad pushed a commit to Luiz-Monad/libiamf that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants