Fix filtering Attachments by only or except setting #3500
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
=======================================
Coverage 97.19% 97.20%
=======================================
Files 287 287
Lines 7559 7586 +27
=======================================
+ Hits 7347 7374 +27
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
66936a2 to
ca5cad4
Compare
2bbb034 to
8a35c23
Compare
37d9827 to
9590b77
Compare
9590b77 to
a22ff5b
Compare
need to rework it. there are still too may UX issues.
820582b to
20750e7
Compare
20750e7 to
02dd52e
Compare
This has been broken for a long time now. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Otherwise it will first be full width and wraps to a new line. Since seletc2 calculates the width this makes sure the input stays on the same line. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Very useful to allow multiple values to be selected for the same filter (ie. file types) Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
If we want to be able to remove an option from the multiple select we need to allow it to clear. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
We want to be able to load file types by extension instead of the full mime type for the File ingredient only and except feature. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
If allowed file extensions are set via the only param, we restrict the available file types to select from to that collection, making sure users cannot attach other files than the allowed ones. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Instead of just the tag list, we make the whole sidebar scrollable, if it exceeds the vertical space left. Makes it much better usable for varying filter counts and heights. Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
989b8c5 to
7f71821
Compare
|
This looks and feels really good! One minor nit: The filters on the overlay accessed from elements look like they can be edited (the tags have |
Interest. Not happening to me. I am still able to remove and add types, as long as they are in the allowed types.
Hmm. Maybe related to your above issue. Not sure what to do about that. We do not want to maintain a list of all available mine types in the world, right? Let's use this for now and fix if they are real world issues. Thanks for taking the time to review this locally. |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
What is this pull request for?
Usually there has been an option to narrow down the file type of
Attachmentsthat can be assigned toan ingredient
Fileby settingonlyand orexceptsetting on the ingredient.But this seems to be broken. This PR re-enables this feature and makes it so much better by using the newly introduced resource filters.
With one allowed file type
With multiple allowed file types
With disallowed file type(s)
Here it shows the list of remaining file types of all file types except the ones disallowed to make it work with the multi select
Checklist