Fix the screen title for each request in the sample app #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, this something we've wanted to fix for a while. However, your approach, while it works now, is still racy with the actual creation of the |
ca4e953 to
385e1b5
Compare
Contributor
Author
|
@jshier Thanks for your reply. I just amended the commit with the suggested change. |
Contributor
|
Thanks! |
jshier
pushed a commit
that referenced
this pull request
Sep 20, 2021
jshier
added a commit
that referenced
this pull request
Sep 20, 2021
* Version to 5.4.4. * Update Ruby dependencies. * Update Jazzy docs. * Fix the screen title for each request in the sample app (#3494) * Add one more PR. Co-authored-by: Tiago Maia <tiago.maia.lopes@gmail.com>
jshier
pushed a commit
that referenced
this pull request
Jan 15, 2022
jshier
added a commit
that referenced
this pull request
Jan 15, 2022
* Version to 5.4.4. * Update Ruby dependencies. * Update Jazzy docs. * Fix the screen title for each request in the sample app (#3494) * Add one more PR. Co-authored-by: Tiago Maia <tiago.maia.lopes@gmail.com>
prongbang
pushed a commit
to prongbang/Alamofire
that referenced
this pull request
May 23, 2025
prongbang
pushed a commit
to prongbang/Alamofire
that referenced
this pull request
May 23, 2025
* Version to 5.4.4. * Update Ruby dependencies. * Update Jazzy docs. * Fix the screen title for each request in the sample app (Alamofire#3494) * Add one more PR. Co-authored-by: Tiago Maia <tiago.maia.lopes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Fix the title of the
DetailViewController, in the iOS sample app. It permanently displays the following title: No request created yet., even after the test request is performed (more context in the gif files).This happens because the
titleis changed too early, before the internalURLRequestgets configured (which is used in thedescriptionproperty).To fix this issue, the controller now assigns a closure to the
onURLRequestCreationmethod on theRequesttype. Inside this closure, it updates its title.Before the change:
After the change: