Codecov Report

Merging #613 (0e81422) into master (702a97c) will decrease coverage by 0.00%.
The diff coverage is 3.03%.

@@            Coverage Diff            @@
##           master    #613      +/-   ##
=========================================
- Coverage    2.97%   2.97%   -0.01%     
=========================================
  Files          35      35              
  Lines        3292    3296       +4     
=========================================
  Hits           98      98              
- Misses       3193    3197       +4     
  Partials        1       1              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I have no idea how to read those Codecov things. I never use it.

will decrease coverage by 0.00%.

Is it actually useful?

idk, I rememember that I was playing with this codecov stuff some time ago.
It is useful in projects that has decent test coverage, but for giu (that, since being a C wrapper) it doesn't seem useful.
At least as long as someone develops a way to write tests for our widgets.

👍 I would suggest disabling codecov then. It's just noise.

I would also suggest enabling "Test and coverage" and "golangci-lint" as required to pass now.

👍 I would suggest disabling codecov then. It's just noise.

I'd turn off only these comments, but idk how 😄
I suppose it should be done by @AllenDang somewhere on codecov's cotrol panel.

I would also suggest enabling "Test and coverage" and "golangci-lint" as required to pass now.

"Test and coverage" is just for codecov, but golangci-lint could be required ofc ;-)

"Test and coverage" is just for codecov

Ah - right. That is the codecov. 😄 I though I saw some tests in there that were being run, but alas there are none.

go test is actually run anyways in the build.yml which is fine if tests are added in the future

So I think we just need to remove coverage.yaml from the workflows?

I suppose it should be done by @AllenDang somewhere on codecov's cotrol panel.

Yes. They don't make it very easy.

Ah here it is: Require status checks to pass before merging in the Settings/Branches/Branch protection rules.

Looks like you have to list them all? Not a great UX!

so its just necessary to add golangci-lint there, since build.yaml is required atm.

From what I read, if you turn it on, you need to add them all (build / Building (ubuntu-latest), build / Building (ubuntu-latest), build / Building (ubuntu-latest), and golangci-lint / Lint).

When I look at another one of my repos, it explicitly lists each item in the matrix...

yah, but build is there already: