Fixed issue with resizing events in GLFW master window #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is because beforeRender() is never called when resizing a GLFW window context.CleanSlate() moved from afterRender() to beginning of render() function. this is because afterRender(), like beforeRender() is never called when resizing it would be ineffective to call CleanSlate() from the sizeChange() function
|
Demonstration videos the problem using the hugelist example Without fix: video-2024-07-31_16.11.32.mp4With fix: video-2024-07-31_16.13.55.mp4 |
|
@JetSetIlly Thanks very much! Good catch! |
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The effect is particularly visible in the drawing of tables during window resizing
beforeRender() now called from sizeChange() in MasterWindow.go. this is because beforeRender() is never called when resizing a GLFW window
context.CleanSlate() moved from afterRender() to beginning of render() function. this is because afterRender(), like beforeRender() is never called when resizing
it would be ineffective to call CleanSlate() from the sizeChange() function. calling CleanSlate() at the beginning of the render() has the same affect as calling it from afterRender() in all situations.