chore: toilet plug improvement & add toilet linker #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the toilet plug functionality and introduces a new toilet linker feature.
- Refactors language keys to use a consistent tooltip key ("tooltip.poopsky.item.info_0") across all locales.
- Updates item class names and associated constants to improve naming consistency (e.g., ToiletPlugItem, ToiletLinkerItem, PoopItem, PoopBallItem).
- Removes the deprecated Plug.java file and updates functionality in related network and block/entity classes.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/assets/poopsky/lang/*.json | Updated tooltip key consistency for toilet plug/linker messages. |
| src/main/java/com/altnoir/poopsky/network/PlugActionPayload.java | Updated references to use the new constant TOILET_PLUG. |
| src/main/java/com/altnoir/poopsky/item/ToiletPlugItem.java | Refactored plug item to use the updated constant and class naming. |
| src/main/java/com/altnoir/poopsky/item/ToiletLinkerItem.java | Added linking functionality with enhanced state management and messaging. |
| src/main/java/com/altnoir/poopsky/item/PoopItem.java, PoopBallItem.java | Renamed classes for clearer intent. |
| src/main/java/com/altnoir/poopsky/item/PSItems.java | Replaced old naming with consistent uppercase constant names. |
| src/main/java/com/altnoir/poopsky/item/PSBaseItem.java | Provided improved shift key detection for tooltip rendering. |
| src/main/java/com/altnoir/poopsky/entity/p/ToiletPlugEntity.java, PSItemModelProvider.java, ToiletComponent.java, PSComponents.java, ToiletBlockEntity.java, AbstractToiletBlock.java | Adjustments to support new linking and plug functionality. |
Comments suppressed due to low confidence (1)
src/main/java/com/altnoir/poopsky/item/ToiletPlugItem.java:55
- Instead of returning the result of super.useOn(context), consider explicitly returning InteractionResult.SUCCESS (or another appropriate InteractionResult) so that the plug placement behavior is clearly defined.
return super.useOn(context);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.