Workflow [PR], commit [b4cb5aa]

Audit: PR #1815 — DataLake setting skip_non_iceberg_tables

AI audit note: This review comment was generated by AI (gpt-5.3-codex).

Audit update for PR #1815 (DataLake setting skip_non_iceberg_tables for Glue and Unity catalogs)

Diff scope: antalya-26.3 → feature/antalya-26.3/test-glue-non-iceberg-hive-table (b4cb5aa6125fc6b7a4f2dc007ccdcc23db54b8d6) — DatabaseDataLakeSettings.cpp, DatabaseDataLake.cpp, GlueCatalog.{h,cpp}, UnityCatalog.{h,cpp}, docs/en/engines/database-engines/datalake.md, tests/integration/test_database_glue/test.py, tests/integration/test_database_delta/test.py.

Confirmed defects

No confirmed defects in reviewed scope.

Coverage summary

• Scope reviewed: skip_non_iceberg_tables setting declaration and wiring in DatabaseDataLake; list-time filtering in GlueCatalog::getTablesForDatabase (Iceberg table_type) and UnityCatalog::getTablesForSchema (isReadableDeltaTable); integration tests for Glue (Hive TEXT) and Unity (TEXT + Delta); documentation in datalake.md.

• Categories failed: (none).

• Categories passed: Glue filter aligns with existing readability rule (table_type must be ICEBERG, case-insensitive); Unity isReadableDeltaTable mirrors tryGetTableMetadata rules (data_source_format == DELTA, securable_kind in TABLE_DELTA / TABLE_DELTA_EXTERNAL); empty() with limit=1 still returns first readable table after skips; no new shared mutable state or locking; bundled fix for wrong placeholder in Unity data_source_format error message (securable_kind → data_source_format in tryGetTableMetadata).

• Assumptions/limits: Static review only; CI not executed in this audit. Unity list responses are assumed to include data_source_format for Spark-created Delta tables (integration test encodes this). With the setting enabled, skipped tables remain reachable by explicit name (SHOW CREATE TABLE, existsTable) — intentional per tests, slightly beyond PR text that only mentions SHOW TABLES / system.tables. Setting name says “iceberg” while Unity filters non-Delta tables — documented in PR/changelog, not a code defect.

Expanded review notes (methodology snapshot)

Call graph (in scope)

1. Config: CREATE DATABASE … SETTINGS skip_non_iceberg_tables=1 → DatabaseDataLake::getCatalog() passes flag into GlueCatalog / UnityCatalog constructors.
2. Listing: getCatalog()->getTables() → Glue getTablesForDatabase / Unity getTablesForSchema → filtered names → DatabaseDataLake::getLightweightTablesIterator / getTablesIterator → SHOW TABLES / system.tables (with show_data_lake_catalogs_in_system_tables=1).
3. Direct access (not filtered): existsTable, SHOW CREATE TABLE, getCreateTableQueryImpl still resolve skipped tables by name; SELECT fails with existing unreadable-table errors (no table_type / ICEBERG for Glue, unsupported data_source_format / DELTA for Unity).

Invariant

When skip_non_iceberg_tables=1, catalog enumeration (getTables and downstream list queries) exposes only tables that would be default-readable under existing per-catalog rules; direct metadata access by known name is unchanged.

Fault categories exercised (logical)

Positive incidental change

UnityCatalog::tryGetTableMetadata error for unsupported data_source_format now prints the actual format value instead of securable_kind (pre-existing message bug fixed in the same diff).

@codex review

Codex Review: Didn't find any major issues. Can't wait for the next one!