feat: add TLS support for Keeper connections#1312
Merged
Merged
Conversation
Slach
requested changes
Dec 24, 2025
Slach
left a comment
Collaborator
There was a problem hiding this comment.
please add parsing /*/client/* from /var/lib/clickhouse/preprocessed_configs/config.xml
when isSecure true instead of using clickhouse TLS connection setting
moreover, could you add zookeeper and keeper tls settings to /tests/integration/docker-compose*.yml and /tests/integration/dynamic_settings.sh
and test it via
RUN_TESTS=^TestS3$ ./test/integration/run.sh
Collaborator
|
thanks you for your contribution |
Pull Request Test Coverage Report for Build 20569484255Details
💛 - Coveralls |
Collaborator
|
@loomts any news about requested changes? |
Slach
requested changes
Dec 28, 2025
Contributor
Author
Slach
approved these changes
Jan 2, 2026
Slach
left a comment
Collaborator
There was a problem hiding this comment.
thanks a lot for your contribution, looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #1311 , to simplify the config, I just reuse the tls config of clickhouse.
According to https://clickhouse.com/docs/operations/ssl-zookeeper, the sample use OS RootCAs, which can also be handle.