fix: updated dashboard templates/queries with correct prometheus metr…#1481
Merged
Slach merged 2 commits intoAltinity:0.24.0from Aug 11, 2024
Merged
Conversation
…ic names Signed-off-by: John Awogboro <ja14000@users.noreply.github.com>>
fc62965 to
adab290
Compare
Slach
requested changes
Aug 9, 2024
Collaborator
Slach
left a comment
There was a problem hiding this comment.
Thank you so much for contribution!
Looks like you have different Prometheus pod scraping config with different label name conversions
Could you return label names back?
Slach
requested changes
Aug 9, 2024
Contributor
Author
Thanks for taking the time to review this, I've restored the original label names, and updated the template queries for |
00aaffb to
ea16538
Compare
Signed-off-by: John Awogboro <ja14000@users.noreply.github.com>
ea16538 to
9f034f2
Compare
Slach
approved these changes
Aug 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zk_avg_latencyrenamed toClickHouseAsyncMetrics_KeeperAvgLatencyzk_max_latencyrenamed toClickHouseAsyncMetrics_KeeperMaxLatencyzk_num_alive_connectionsrenamed toClickHouseMetrics_KeeperAliveConnectionszk_packets_sentrenamed toClickHouseAsyncMetrics_KeeperPacketsSentzk_packets_receivedrenamed toClickHouseAsyncMetrics_KeeperPacketsReceivedzk_znode_countrenamed toClickHouseAsyncMetrics_KeeperZnodeCountzk_watch_countrenamed toClickHouseAsyncMetrics_KeeperWatchCountzk_ephemerals_countrenamed toClickHouseAsyncMetrics_KeeperEphemeralsCountzk_approximate_data_sizerenamed toClickHouseAsyncMetrics_KeeperApproximateDataSizezk_outstanding_requestsrenamed toClickHouseMetrics_KeeperOutstandingRequestszk_open_file_descriptor_countrenamed toClickHouseAsyncMetrics_KeeperOpenFileDescriptorCountThis resolves the issue described here and the dashboard now works normally.