Add support for Cartesian paths#8
Conversation
|
Hello @Schnilz,
I have to agree that the generic ROS 2 interface of MoveIt 2 can be a bit difficult to follow. Maybe there is a much simpler way, but I have not found it yet. The code in this repo can be quite ugly, especially when trying to reduce the number of memory allocation calls and create only clients that are actually used. I also noticed a difference in performance between services and actions that achieve the same goal. That's why both options are currently available, despite adding yet another level of ugliness to the code. |
AndrejOrsula
left a comment
There was a problem hiding this comment.
Thank you again for this PR! It works and looks good to me. 😄 I added some cosmetic comments.
Could you run the pre-commit hooks (it will fix formatting and sort imports)? There is a small setup script under .git_hooks/setup.bash that would install it on your system and setup the repository. If not, I will run them before merge.
* Add support for Cartesian paths (#8) * Add support for collision objects (#9) * Remove trimesh from ROS 2 dependencies Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com> * Expose cartesian planning as a parameter in the pose goal example Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com> * Add default test mesh for collision object example Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com> * Move public functions before private Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com> Co-authored-by: Nils Schulte <47043622+Schnilz@users.noreply.github.com>
Merge upstream into this repo
Hi,
thank you for writing this, especially with the good examples :)
I missed the cartesian planner, so i added it here.
I don't know why the moveit2 interface is so weird, but the code works (and calls the same service as the GUI in rviz does i think).
closes #6