Skip to content

Feature/API_functionalities and Makedevices#104

Merged
ravescovi merged 16 commits into
mainfrom
feature/delete-bits
Apr 18, 2025
Merged

Feature/API_functionalities and Makedevices#104
ravescovi merged 16 commits into
mainfrom
feature/delete-bits

Conversation

@ravescovi

@ravescovi ravescovi commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

Description

This adds some api functionalities and creates the api folder. It organizes a bit better the place where the side functionalities that are only available "outside of python" could live.

  • delete-bits
  • run-bits

It also adds some minor changes to make_devices

  • make_devices straight from a specific file.

Fixes # (issue)

Type of change

Choose which options apply, and delete the ones which do not apply.

  • New feature (non-breaking change that adds functionality)
  • Documentation update

@coveralls

coveralls commented Apr 17, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14539078544

Details

  • 378 of 433 (87.3%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 86.277%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/apsbits/api/run_instrument.py 43 44 97.73%
src/apsbits/tests/test_run_instrument.py 101 103 98.06%
src/apsbits/tests/test_delete_instrument.py 163 166 98.19%
src/apsbits/api/delete_instrument.py 55 61 90.16%
src/apsbits/utils/make_devices.py 13 31 41.94%
src/apsbits/utils/config_loaders.py 3 28 10.71%
Files with Coverage Reduction New Missed Lines %
src/apsbits/utils/make_devices.py 4 71.57%
Totals Coverage Status
Change from base Build 14315368140: 0.8%
Covered Lines: 1270
Relevant Lines: 1472

💛 - Coveralls

@ravescovi ravescovi self-assigned this Apr 17, 2025
@ravescovi ravescovi added the enhancement New feature or request label Apr 17, 2025
@ravescovi ravescovi changed the title Feature/New_functionalities Feature/API_functionalities and Makedevices Apr 18, 2025
Comment thread .github/workflows/code.yml Outdated
run: |
set -vxeuo pipefail
pip install -e .
pip install -e ".[dev]"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes are not necessary for the bash shell used in this workflow. Please remove.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@prjemian prjemian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravescovi ravescovi merged commit ed3e521 into main Apr 18, 2025
@ravescovi ravescovi deleted the feature/delete-bits branch April 18, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants