android: new domain name creation method#4176
Open
truboxl wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jia Yuan Lo <jylo06g@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4176 +/- ##
===========================================
+ Coverage 2.86% 6.99% +4.13%
- Complexity 0 756 +756
===========================================
Files 178 278 +100
Lines 27832 35087 +7255
Branches 0 1526 +1526
===========================================
+ Hits 797 2454 +1657
- Misses 27035 32521 +5486
- Partials 0 112 +112 🚀 New features to boost your workflow:
|
Contributor
Author
|
Information for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2846
Description of the Change
New domain name will be created based on brand, model, random strings on Android, else fallback to old way if something went awry
Alternate Designs
No idea how to do this using Java / Kotlin
I pick brand over manufacturer, since some phones have brand "Nokia" but manufacturer "HMD Global"
Release Notes
client: new android domain name creation method