Allow multi-byte character literals #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the optional length check when parsing character literals (e.g. `'IHDR'`), making `cppp` able to process header files that make use of this commonly-used extension.
Owner
|
Unfortunately, this deletion is not enough by itself to correctly handle multicharacter literals. If such literals are permitted, then they can also appear in preprocessor expressions, so cppp needs to be able to correctly evaluate them as well. (For certain interpretations of "correctly" anyway, since their actual values are implementation-defined.) (Also, please note that this code is actually out of date. The website https://www.muppetlabs.com/~breadbox/software/cppp.html always points to the current version, which is at https://git.sr.ht/~breadbox/cppp. My apologies for the confusion.) |
|
@BR903 Maybe archive this repo and point to the current repo in the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the optional length check when parsing character literals (e.g.
'IHDR'), makingcpppable to process header files that make use of this commonly-used extension.