Rewrite symbolic perturbation algorithm#11
Draft
luisfonsivevo wants to merge 2 commits into
Draft
Conversation
This was referenced Nov 28, 2025
Closed
Member
Author
|
There is an official fix available now that should far outperform this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rough draft fix for elalish/manifold#1430. Full details of how this works can be found in the conversation thread. It should be able to handle a boat load more edge cases, as long as the coordinates flowing through
fn shadows()are floating point equal. This is more of a mathematical demonstration/request for comment than a true pull request. At the bare minimum, some optimization is necessary before merging.