Skip to content

Conversation

@bartblaze
Copy link
Contributor

@bartblaze bartblaze commented Nov 23, 2025

Upd URL shorteners (thnx MISP Warninglist)

Minor fixes

Add LNK Yara rule

Add new sig for password DB files

Upd URL shorteners (thnx MISP Warninglist)

Add LNK Yara rule

Add new sig for password DB files
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bartblaze, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several important updates aimed at bolstering threat detection. It includes the addition of a new YARA rule to identify WebDAV usage in LNK files, significantly expands the lists of known URL shortener domains across multiple network signatures to better detect command-and-control channels, and adds a new signature to flag access to common password database files. These changes collectively enhance the system's ability to identify malicious activity related to shortcut files, suspicious network communications, and credential theft attempts.

Highlights

  • New YARA Rule: A new YARA rule WebDAV_in_LNK has been added to detect WebDAV paths within LNK (shortcut) files, enhancing threat detection capabilities.
  • Expanded URL Shortener Lists: The lists of recognized URL shortener domains have been significantly updated and expanded in both NetworkCnCHTTPSURLShortenerSite and NetworkDNSURLShortener signatures, improving detection of C2 communication and suspicious network activity.
  • New Password Database Signature: A new signature ReadsPasswordDatabase has been introduced to identify when processes access files commonly associated with password databases (e.g., KeePass, 1Password, Enpass), aiding in credential access detection.
  • Signature Refinements: Minor corrections were made to signature names and descriptions for improved accuracy and clarity, including fixing a typo and enhancing a description for Telegram exfiltration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several updates, including expanding the list of URL shorteners, adding a new YARA rule for detecting WebDAV in LNK files, and creating a new signature for identifying access to password database files. The changes are beneficial, but there are opportunities for improvement. Notably, the list of URL shorteners is duplicated across two files, which should be refactored to improve maintainability. Additionally, the implementation of the new password database signature can be made more concise.

@doomedraven doomedraven merged commit a27ec31 into CAPESandbox:master Nov 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants