Skip to content

Add support for generating observations for non depth variables #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
selimnairb merged 13 commits into from
May 8, 2025
Merged

Add support for generating observations for non depth variables #21

selimnairb merged 13 commits into from
May 8, 2025

Conversation

@selimnairb
Copy link
Member

@selimnairb selimnairb commented Apr 10, 2025

Implements initial support for non-depth variables, currently, water temperature. Support for other NMEA0138 and NMEA2000 variable can be added in the future. This PR also adds a vbi command line tool that features a dump command to write ASCII versions of logger data files supported by OpenVBI to the screen or to a file. This is useful for debugging (I used it to help develop non-depth variable support).

selimnairb added 10 commits March 27, 2025 17:52
@selimnairb
#18 Add notes on where to get SOG and env parameters
cb149be
@selimnairb
#18 Progress towards adding support for ancillary variable timestamping
e48b2a6
@selimnairb
#18 Add cli multi tool, initially only containing a dump command to d…
166327a 
…ump logger file packets to ASCII for debugging purposes
@selimnairb
#18 Update TeamSurv adaptor to support parsing timestamp from RMC as …
79e6164 
…well as ZDA sentences
@selimnairb
#18 Generalize variable handling for observations.generate_observatio…
bb3ac80 
…ns() to handle non-depth variables; Add initial support for reporting water temperature
@selimnairb
#18 Generalize support for loading compressed files in Loader impleme…
93a7964 
…ntations
@selimnairb
#18 Initial working support for multiple variable interpolation
ea71612
@selimnairb
Add test/example of generating non-depth data as CSV
263ea2f
@selimnairb
#18 Add example of outputting non-depth data
ccdde12
@selimnairb
#18 Add usage documenation to README
e8f42a1
@selimnairb selimnairb linked an issue Apr 10, 2025 that may be closed by this pull request
Add support for generating observations for non-depth variables #18
Closed
brian-r-calder
brian-r-calder approved these changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@brian-r-calder brian-r-calder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer the "todo" work in observations.py be in a separate file, but otherwise this should be good.

@selimnairb
Copy link
Member Author

selimnairb commented May 1, 2025

I think I would prefer the "todo" work in observations.py be in a separate file, but otherwise this should be good.

How about I create a directory called docs/dev and therein place a file called TODO.md that has the notes on the NMEA2000 and NMEA0183 messages we'd like to add support for in observations.py?

@brian-r-calder
Copy link
Collaborator

brian-r-calder commented May 1, 2025

I think I would prefer the "todo" work in observations.py be in a separate file, but otherwise this should be good.

How about I create a directory called docs/dev and therein place a file called TODO.md that has the notes on the NMEA2000 and NMEA0183 messages we'd like to add support for in observations.py?

That'll work, I think.

@selimnairb selimnairb merged commit 91994ee into main May 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-r-calder brian-r-calder brian-r-calder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for generating observations for non-depth variables

3 participants

@selimnairb @brian-r-calder